This project is archived and is in readonly mode.
Nokogiri XmlMini code is broken on 2-3-stable
Reported by CancelProfileIsBroken | September 21st, 2009 @ 11:55 PM | in 2.3.6
ActiveSupport::XmlMini_Nokogiri#parse is busted on 2-3-stable because it uses "string" to name a parameter and later tries to refer to this same parameter as "data". As a result, a dozen tests fail.
- Failures are not detected on CI because Nokogiri isn't installed on CI server
- Code in master is different (and good) due to major rewrites
Attached patch fixes 2-3-stable to work properly if Nokogiri is installed
Comments and changes to this ticket
-
Repository September 22nd, 2009 @ 12:24 AM
- State changed from “new” to “resolved”
(from [6222ac1a91e5beb44d875ec9c0072bbac6f3d04d]) Fix variable error in Nokogiri XmlMini code [#3242 state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com
http://github.com/rails/rails/commit/6222ac1a91e5beb44d875ec9c0072b...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
CancelProfileIsBroken
Pratik
Attachments
Referenced by
-
3242
Nokogiri XmlMini code is broken on 2-3-stable
(from [6222ac1a91e5beb44d875ec9c0072bbac6f3d04d])
Fix var...