Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Nokogiri XmlMini code is broken on 2-3-stable

#3242

ActiveSupport::XmlMini_Nokogiri#parse is busted on 2-3-stable because it uses "string" to name a parameter and later tries to refer to this same parameter as "data". As a result, a dozen tests fail.

  • Failures are not detected on CI because Nokogiri isn't installed on CI server
  • Code in master is different (and good) due to major rewrites

Attached patch fixes 2-3-stable to work properly if Nokogiri is installed

Reported by CancelProfileIsBroken · September 21st, 2009 @ 11:55 PM

State: resolved
Milestone: 2.3.6
Assigned to: Pratik Pratik
Importance: none

Activity