nested fields_for with index should account for the index

new patch with modified regex that works a lil better for me.

the updated patch for real this time

Kevin, how does this handle nested fields_for with indexes on each fields_for? Don't have time to test myself.

I do like this though. Just making sure it doesn't clash now that our other patch was committed.

This does work with indexes on the nested fields for. (It is actually what I use this for.)

form_for(:post, @post, :index => 1) do |f|
  f.fields_for(:comment, @post, :index => 5) do |c|
    concat c.text_field(:title)
  end
end

produces

<form action="http://www.example.com" method="post">
  <input name="post[1][comment][5][title]" size="30" type="text" id="post_1_comment_5_title" value="Hello World" />
</form>

Was that in the test coverage? I musta missed in reading quickly.

no it isn't in the patch. I just assumed it would be assumed that everything else continued to work. I suppose I should add it in.

I guess I'm used to assuming nothing works without a test. [That wasn't meant to sound as TDDier-than-thou as it might].

well those tests only showed the exact behaviour that changed, but no one ever complains about test being to explicit. More tests are on the way.

s/to/too

It is a good thing you had me write those tests. I discovered that nested auto_index didn't work. Now it does along with more tests to cover that the inner fields_for having index and auto index work.

updating patch to apply cleanly to edge. I think the only difference is in the hashes and line numbers, but I get an error with the old patch for some reason.

And apparently I can't delete my old attachments anymore.

+1 here.

Automatic cleanup of spam.

Automatic cleanup of spam.

gucci watches