Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

[PATCH] Clean up "omg" comments

#3325

There are many stray "omg"-like comments in our source. I do not want to see any of these showing up in our official rdoc when we publish. If a comment is needed to note something that should be fixed, make sure it is turned off in rdoc and prefixed w/ "TODO:" or "FIXME:" conventions.

Reported by josh · October 4th, 2009 @ 05:31 PM

State: resolved
Milestone: 3.0.2
Assigned to: nobody
Importance: Low

Activity

  1. Jakub Hampl
    Jakub Hampl

    I removed or changed comments that seemed inappropriate, eg. contained the word fuck.

    The source code also contains many bizarre class names like:

    class OmgOmg
    end
    

    and so one.

    Shouldn't these be removed/changed as well?

    November 9th, 2009 @ 08:17 PM

  2. Rizwan Reza
    Rizwan Reza
    • Tag set to 3.0, patch, review

    This wasn't applying. Recreated the patch with some amendments.

    January 16th, 2010 @ 09:19 PM

  3. Rizwan Reza
  4. Rizwan Reza
    Rizwan Reza
    • Title changed from Clean up "omg" comments to [PATCH] Clean up "omg" comments

    January 16th, 2010 @ 09:47 PM

  5. Ryan Bigg
  6. Rizwan Reza
    Rizwan Reza

    I will ask someone from the core to guide me on that. There are lots of reference to OMG. My premise was to remove all foul language from the source code and take out all OMGs that can get into rdocs somehow.

    January 17th, 2010 @ 07:34 AM

  7. Rizwan Reza
    Rizwan Reza
    • State changed from new to open
    • Tag changed from 3.0, patch, review to 3.0, documentation, patch, review
    • Assigned user changed from Yehuda Katz (wycats) to Mikel Lindsaar

    January 20th, 2010 @ 10:49 AM

  8. Rizwan Reza
    Rizwan Reza
    • State changed from open to resolved
    • Assigned user cleared.

    January 20th, 2010 @ 11:07 AM

  9. Mikel Lindsaar
  10. Ryan Bigg
    Ryan Bigg
    • Tag cleared.
    • Importance changed from to Low

    Automatic cleanup of spam.

    October 9th, 2010 @ 09:52 PM

  11. Ryan Bigg
    Ryan Bigg

    Automatic cleanup of spam.

    October 11th, 2010 @ 12:13 PM

  12. Jeremy Kemper
  13. bingbing