#3325 [PATCH] Clean up "omg" comments - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#3325 ✓resolved

[PATCH] Clean up "omg" comments

Reported by josh | October 4th, 2009 @ 05:31 PM | in 3.0.2

There are many stray "omg"-like comments in our source. I do not want to see any of these showing up in our official rdoc when we publish. If a comment is needed to note something that should be fixed, make sure it is turned off in rdoc and prefixed w/ "TODO:" or "FIXME:" conventions.

Comments and changes to this ticket

You flagged this item as spam.
Jakub Hampl November 9th, 2009 @ 08:17 PM
I removed or changed comments that seemed inappropriate, eg. contained the word fuck.

The source code also contains many bizarre class names like:
```
class OmgOmg
end
```
and so one.

Shouldn't these be removed/changed as well?
- removed-omg-comments.diff 3.1 KB
Rizwan Reza January 16th, 2010 @ 09:19 PM
- Tag set to “3.0, patch, review”
This wasn't applying. Recreated the patch with some amendments.
- 0001-remove-foul-language.patch 2.4 KB
Rizwan Reza January 16th, 2010 @ 09:25 PM
Applies cleanly.
Rizwan Reza January 16th, 2010 @ 09:47 PM
- Title changed from “Clean up "omg" comments” to “[PATCH] Clean up "omg" comments”
Ryan Bigg January 17th, 2010 @ 06:07 AM
You missed one: http://github.com/rails/rails/blob/3022ce4f723075d201d9a20f7bca3537...
Rizwan Reza January 17th, 2010 @ 07:34 AM
I will ask someone from the core to guide me on that. There are lots of reference to OMG. My premise was to remove all foul language from the source code and take out all OMGs that can get into rdocs somehow.
Rizwan Reza January 20th, 2010 @ 10:49 AM
- State changed from “new” to “open”
- Tag changed from “3.0, patch, review” to “3.0, documentation, patch, review”
- Assigned user changed from “Yehuda Katz (wycats)” to “Mikel Lindsaar”
Rizwan Reza January 20th, 2010 @ 11:07 AM
- State changed from “open” to “resolved”
- Assigned user cleared.
Mikel Lindsaar February 1st, 2010 @ 12:29 PM
Actually, commit http://github.com/rails/rails/commit/2ebea1c02d10e0fea26bd98d297a8f... closes this.

Mikel
Ryan Bigg October 9th, 2010 @ 09:52 PM
- Tag cleared.
- Importance changed from “” to “Low”
Automatic cleanup of spam.
Ryan Bigg October 11th, 2010 @ 12:13 PM
Automatic cleanup of spam.
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
[bulk edit]
You flagged this item as spam.
bingbing March 26th, 2011 @ 02:07 AM
louis vuitton watches
You flagged this item as spam.
klkk May 23rd, 2011 @ 02:53 AM
louisvuittonwarehouse.com
You flagged this item as spam.
klkk May 23rd, 2011 @ 02:54 AM
www.louisvuittonwarehouse.com