This project is archived and is in readonly mode.

#3329 ✓resolved
josh

Expose "run_foo_callbacks" callbacks api

Reported by josh | October 4th, 2009 @ 05:41 PM | in 3.0.2

I noticed you cheating in abstract controller. We are abusing our own api rules by calling a private "_" method in a different module.

    def process_action(method_name)
      _run_process_action_callbacks(method_name) do
        super
      end
    end

It should be using "run_callbacks :process_action". However, think we should just fully expose the nicer generated methods as the public api.

  • Rename "_run_foo_callbacks" to "run_foo_callbacks"
  • Document it as the main api
  • Put a deprecation notice in "run_callbacks"

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Referenced by

Pages