Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

[PATCH] Update vendored i18n gem to version 0.3.3

#3492

Rails is still shipping I18n 0.1.3. Let's upgrade it to the current version 0.2.1.

http://github.com/svenfuchs/i18n/blob/master/CHANGELOG.textile

(From 0.2.0 to 0.2.1 that was a tiny bug fix. Gotta update the changelog over there.)

Patch is attached, tests pass for me (can't currently run postgres and mysql though).

Reported by Sven Fuchs · November 18th, 2009 @ 11:55 AM

State: resolved
Milestone: 2.3.6
Assigned to: José Valim José Valim
Importance: none

Activity

  1. Jeremy Kemper
    Jeremy Kemper
    • State changed from new to open

    Hey Sven, I happened to try this a few days ago but ran into breakage on Ruby 1.9.

    On 1.8, all tests pass except AS test_time_zone_localization_with_default_format: "Sat, 01 Jan 2000 00:00:00 -0800" expected but was "Wed, 01 Jul 2000 00:00:00 -0800"

    On 1.9: same AS failure, three AP failures with test_number_to_human_size (ArgumentError: malformed format string - %n), and two AMo failures (e.g. test_percent_s_interpolation_syntax_in_error_messages_was_deprecated).

    November 18th, 2009 @ 07:37 PM

  2. Sven Fuchs
    Sven Fuchs

    Ummmm ...

    Ok, the failing test on 1.8 looks like you've tried I18n 0.2.0. iirc that's the bug we've fixed in 0.2.1

    Dunno about 1.9 though - will look into it asap. Thanks! :)

    November 18th, 2009 @ 08:50 PM

  3. Jeremy Kemper
    Jeremy Kemper

    Could you release a 0.2.1 (or 0.2.1.pre) gem?

    November 18th, 2009 @ 09:13 PM

  4. Sven Fuchs
    Sven Fuchs

    Hi Jeremy,

    I've fixed a few Ruby 1.9 issues and will do another bugfix release 0.2.2 for these (0.2.1 is on gemcutter meanwhile): http://github.com/svenfuchs/i18n/commits/0.2.x

    I've removed the old patch and will attach a new one that contains these fixes and already uses the version number 0.2.2. Tests pass on Ruby 1.9 now, too.

    I'll push the 0.2.2 gem as soon as you've merged the patch - just in case you still find something that needs to be fixed :)

    Thanks!

    November 19th, 2009 @ 09:54 PM

  5. Sven Fuchs
    Sven Fuchs

    Hi Jeremy,

    I've merged your changes from http://github.com/jeremy/i18n/commits to master: http://github.com/svenfuchs/i18n/commits/master

    Thanks :)

    November 20th, 2009 @ 12:09 PM

  6. stanislav
    stanislav
    • Tag changed from gem, i18n, vendor to gem, i18n, ruby1.9, vendor
    • Assigned user cleared.

    I have one more issue with ruby 1.9 and the gem for i18n.

    In our project we're using strings as keys and as a result I get this Exception:

    undefined method inject' for "Андора":String<br/> .../ruby-1.9.1-p376/gems/activesupport-2.3.5/lib/active_support/vendor/i18n-0.1.3/lib/i18n/backend/simple.rb:206:indeep_symbolize_keys'

    January 7th, 2010 @ 10:26 AM

  7. Prem Sichanugrist (sikachu)
    Prem Sichanugrist (sikachu)
    • Assigned user set to Prem Sichanugrist (sikachu)

    @stanislav

    Please try to install latest i18n gem (0.3.3) and see if problem still exists.

    I'll upload patch for 2-3-stable with i18n-0.3.3 soon.

    January 21st, 2010 @ 06:40 AM

  8. Prem Sichanugrist (sikachu)
    Prem Sichanugrist (sikachu)
    • Tag changed from gem, i18n, ruby1.9, vendor to gem, i18n, patch, review, ruby1.9, vendor
    • Assigned user changed from Prem Sichanugrist (sikachu) to José Valim

    All tests pass on i18n-0.3.3 with Ruby 1.8.7p174 and 1.9.1p376

    All tests pass on active_support after update the vendored gem on 2-3-stable

    Please review this patch :)

    January 21st, 2010 @ 07:23 AM

  9. Prem Sichanugrist (sikachu)
    Prem Sichanugrist (sikachu)
    • State changed from open to verified
    • Title changed from Update vendored i18n gem to version 0.2.1 to [PATCH] Update vendored i18n gem to version 0.3.3

    January 21st, 2010 @ 07:24 AM

  10. Repository
    Repository

    January 21st, 2010 @ 08:48 AM

  11. José Valim
    José Valim
    • State changed from verified to resolved

    January 21st, 2010 @ 08:48 AM