This project is archived and is in readonly mode.
[PATCH] Autolinking non-http protocols doesn't work
If you redefined the AUTO_LINK_RE to support protocols other than HTTP, bad links are generated. In the auto_link_urls code it checks if there is an http in the generated href and if there isn't it prepends one. If you're using auto_link_urls on, for example, ftp:// links, instead of <a href="ftp://example.com">ftp://example.com</a> , you get <a href="http:// ftp://example.com">ftp://example.com</a>. This patch adds a test and changes the code to check for any protocol instead of just http before prepending the default.
This patch is against the 2-3-stable branch.
-
auto_link_other_protocol.diff
2.52 KB
-
Zach Brock- Tag changed from actionview, auto_link, patch, rails, text_helper to 2.3.x, actionview, auto_link, patch, rails, text_helper
-
Zach Brock
Here's a new patch against 2-3-stable that scopes the regex to the beginning of the url
-
-
Josh Susser
+1 works for me. Can we get this on 2-3-stable soon?
-
Repository
- State changed from new to committed
(from [f32c96eb760abca984b86435f89b7bbc149e78c7]) fixing autolinking other protocols
Signed-off-by: Michael Koziarski michael@koziarski.com
[#3494 state:committed] http://github.com/rails/rails/commit/f32c96eb760abca984b86435f89b7b... -
Repository
- State changed from committed to resolved
(from [bd9ca9aed0b5ab3697a7ae27a53664f3118b132c]) auto_link: support arbitrary URI schemes like "ftp:" and "file:"
recognizes all URI scheme allowed characters, such as colon and period.
[#3494 state:resolved] http://github.com/rails/rails/commit/bd9ca9aed0b5ab3697a7ae27a53664...
-
Repository
(from [133ada6ab0f0cb7bef2bd40dbc18f2d5bc6b964e]) auto_link: support arbitrary URI schemes like "ftp:" and "file:"
recognizes all URI scheme allowed characters, such as colon and period.
[#3494 state:resolved] http://github.com/rails/rails/commit/133ada6ab0f0cb7bef2bd40dbc18f2...