Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Print partial name in HTML, in development mode

#3532

http://github.com/anildigital/partioprint Rails plugin prints partial names in HTML as html comments. I feel it;s functionality should part of Rails core which can be enabled or disabled. The other option is to add a app config which when ON can turn this code on. Any suggestions?

Reported by Anil Wadghule · December 1st, 2009 @ 08:04 PM

State: wontfix
Milestone: none
Assigned to: DHH DHH
Importance: Low

Activity

  1. Craig Buchek
    Craig Buchek
    • Tag changed from html comment partials, rails to html comment partials, feature_request, partials, rails
    • Assigned user set to DHH

    This sounds like a good idea, but should only be enabled in non-production environments. (And easily turned off or on.)

    That said, this is a feature request, and would need to have a patch against Rails master to get integrated into Rails.

    I'd also suggest that you get your users to +1 it here.

    Assigning to DHH due to his "Rave Review" at the bottom of http://github.com/anildigital/partioprint ;)

    April 13th, 2010 @ 01:54 AM

  2. Brian Rose
    Brian Rose

    I definitely understand the usefulness, but I don't understand why it should be part of Rails. Keeping it in a plugin seems like the right way to go, imo.

    April 13th, 2010 @ 02:15 AM

  3. Amos King
    Amos King

    I think it should stay as a patch. A framework should optimize because you don't know the end user's use case all the time, and if they have a lot of partals that is a lot of extra info down the wire, and exposes part of your implementation that many companies may not want to happen. I think keep it as a plugin. If you want it make it only work if you turn it on.

    April 14th, 2010 @ 02:04 AM

  4. Ryan Bigg
    Ryan Bigg
    • State changed from new to wontfix

    Yes, I agree keep it as a plugin. That's 3 -1s so...

    April 14th, 2010 @ 04:13 AM

  5. Ryan Bigg
    Ryan Bigg
    • Tag cleared.

    Automatic cleanup of spam.

    October 9th, 2010 @ 10:10 PM