Let label helpers accept blocks

Double bonus for this enhancement -thanks Stephen. I see that you have also made the "name" attribute optional -fantastic. Now one can implicitly apply a label to the enclosed input without having to worry about id matching with the 'for' attribute:

label_tag nil, "Your Name" do
text_field_tag 'name' end

IMO, the signature of #label_tag (and #label) should evolve to better support this practice as it reduces the need to keep DOM ids in sync between the input and the label. Perhaps by counting args to label_tag and assuming a single string argument is a contextual label.

Pretty cool!

I use a lot of labels with images inside, especially on radiobuttons and checkboxes to be able to check the corresponding field without having to resort to javascript, and things usually get very messy having to add them inside the label and label_tag methods. So this patch is something i'm realy looking for! Do you need help with anything?

Biggest help would be to test the patch out and get others to do so.

Once a few people approve, we can mark this "confirmed."

Updated patch rebased against master.

It's a good feature,

I try, run the test and work fine.

Thank you Stephen

+1

Applies cleanly to master, great patch!

+1

Applies cleanly to master and tests pass. Nice work.