#3646 HTML5 form field helpers (email_field_tag, etc.) - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#3646 ✓committed

HTML5 form field helpers (email_field_tag, etc.)

Reported by Stephen Celis | January 3rd, 2010 @ 07:05 PM | in 3.0.2

As HTML5 becomes more popular, it would be nice to have convenience methods for the new input types.

This patch includes and tests the following:

email_field_tag (and email_field)
url_field_tag (etc.)
telephone_field_tag (aliased to phone_field_tag)
number_field_tag
range_field_tag
search_field_tag

All of the above function on (Mobile) Safari and Opera, and all will gracefully degrade across other browsers.

html5-form-helpers.diff 9.6 KB

Comments and changes to this ticket

You flagged this item as spam.
Tony Pitale January 4th, 2010 @ 04:22 AM
+1

Good first step.
Ryan Bigg January 5th, 2010 @ 03:53 AM
+1

I think it's best to have this in now (3.0) than later.
You flagged this item as spam.
Stephen Celis January 5th, 2010 @ 02:34 PM
Additional patch that merely fixes the "text_field type: override" bug.

Discussion here: http://groups.google.com/group/rubyonrails-core/browse_thread/threa...

I still think that we should prefer adding the helpers, as well, to encourage their use.
- accept-alternate-text-field-types.diff 1.8 KB
You flagged this item as spam.
Dan Croak January 5th, 2010 @ 05:13 PM
+1 the accept-alternate-text-field-types.diff patch.
You flagged this item as spam.
Alex Kahn January 6th, 2010 @ 04:05 PM
+1 This is beautiful.
You flagged this item as spam.
Maxim Filatov January 6th, 2010 @ 08:45 PM
+1
You flagged this item as spam.
Kevin McFadden January 8th, 2010 @ 04:29 PM
+1
You flagged this item as spam.
Bruce Williams January 8th, 2010 @ 08:16 PM
+1 the accept-alternate-text-field-types.diff patch.
Repository January 14th, 2010 @ 01:03 AM
(from [2835ec6134b1e5b706824b568dfaba24672b7409]) Custom 'type' attribute support for text_field. [#3646 status:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/2835ec6134b1e5b706824b568dfaba...
José Valim January 14th, 2010 @ 01:08 AM
- State changed from “new” to “resolved”
- Assigned user set to “José Valim”
Jeremy Kemper April 5th, 2010 @ 11:57 PM
- Milestone cleared.
- State changed from “resolved” to “open”
Let's get the full helpers in. Could you rebase against master?
Jeremy Kemper April 6th, 2010 @ 12:02 AM
Interested in seeing autofocus and placeholder support with javascript fallback, too, if anyone wants to tackle in another ticket.
Repository April 6th, 2010 @ 12:08 AM
- State changed from “open” to “committed”
(from [f8730e5ce6bba4de7639ac09c6c193458038f748]) Added all the new HTML5 form types as individual form tag methods (search, url, number, etc) (Closes #3646) [Stephen Celis] http://github.com/rails/rails/commit/f8730e5ce6bba4de7639ac09c6c193...
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
[bulk edit]
You flagged this item as spam.
michaelxavier April 9th, 2011 @ 04:33 AM
Hate to necro but is there any possible way to get this backported to 2.X? It is surprisingly painful to retrofit existing forms with HTML5 input types.
You flagged this item as spam.
Justin French April 9th, 2011 @ 06:22 AM
@michaelxavier is it really that painful? text_field(:user, :email_address, :type => :email) has worked pretty well for me.