This project is archived and is in readonly mode.
HTML5 charset
Rails error pages, public/index.html, and app/layout all use HTML5 now. The HTML5 specification has a shorter way of setting character encoding.
http://dev.w3.org/html5/html4-differences/#character-encoding
That's all this patch does, continuing on this commit by Josh Peek:
http://github.com/rails/rails/commit/01d92021e69f54def1ec8103b2b99f...
Attached a diff per the Lighthouse instructions. Can be viewed with nice coloration at Github:
http://github.com/dancroak/rails/commit/62c7964c7a60091cfd8250c701b...
http://github.com/dancroak/rails/commit/aff1dbc33fe559b7a3e95342eee...
I didn't change any tests as they look like they simply test that the layout file is created:
http://github.com/dancroak/rails/blob/3f28e0bda6386ed25d07182dd39b8...
-
html5-charset.diff
4.24 KB
-
-
Tristan Dunn+1
-
Mark Turner+1
-
Jeremy Kemper- Assigned user set to josh
- State changed from new to open
- Milestone cleared.
<meta charset=utf-8>is a bit shorter, and a BOM is shorter still... -
joshDo we even need that line at all? We set the Content-Type header correctly.
Content-Type: text/html; charset=utf-8 -
Dan CroakJosh,
Yes, if Rails is correctly setting the Content-Type header, then those lines are unnecessary in HTML5.
Attached a self-contained, one commit patch that removes those lines.
-
html5-charset.diff
3.79 KB
-
-
josh
- State changed from open to committed
-
Jeremy Kemper
Rails doesn't set the header when the public files are served by apache/nginx/httpd directly, so they have metas in case the server isn't configured to use UTF-8 default. Using a BOM would work around that as well.
-
Dan Croak
Jeremy,
I don't really understand the BOM but I see what you're saying about the public files.
If you want it, I attached another patch that brings back the short meta charset tags for just the public files (the erb layout remains without any meta tag or BOM).
Thanks for sweating the details, guy. I realize this was very low on the list of priorities.
-
Dan Croak
*guys
-