This project is archived and is in readonly mode.

[PATCH] include paths for gem bundler in generated gitignore

#3725

Rails 3 now generates a gitignore file for you:

db/*.sqlite3
log/*.log
tmp/**/*

However, it doesn't include paths to match the files gem bundle would generate. I generally have to look this up everytime, since I haven't seen an authoritative way to deal gem bundler in a project. According to it's docs, it should be something like:

vendor/gems/*
!vendor/gems/ruby/1.8/cache/

It probably makes sense to include some pattern that will work with bundler out of the box, as to avoid confusion of what to git add and what to ignore.

Reported by Josh Nichols · January 17th, 2010 @ 06:11 PM

Activity

Rizwan Reza
- Tag changed from gitignore, rails3, rails_generator to bugmash, generators, gitignore, rails3, rails_generator, review
- Assigned user set to José Valim
- Title changed from include paths for gem bundler in generated gitignore to [PATCH] include paths for gem bundler in generated gitignore
The patch attached takes all paths described in Bundler docs. This takes one nuisance away from setting up rails app for development. Recommended.

I have verified by reapplying the patch.
- 0001-include-paths-recommended-by-bundler-in-gitignore.patch 856 Bytes
January 17th, 2010 @ 08:00 PM
Prem Sichanugrist (sikachu)
This patch doesn't apply anymore on master. I've attached the modified version.
- 0001-include-paths-recommended-by-bundler-in-gitignore-20100121.patch 832 Bytes
January 20th, 2010 @ 06:13 PM
Prem Sichanugrist (sikachu)
- State changed from new to hold
just realize that the patch above won't work with Ruby 1.9, since gem would be puts in different directory.

I will put this patch on hold until @wycats done with Bundler.

January 21st, 2010 @ 06:20 PM
Prem Sichanugrist (sikachu)
- State changed from hold to invalid
It seems like this patch doesn't applied with Bundler 0.9.x anymore. Should be closed.

February 11th, 2010 @ 03:33 PM