Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

[PATCH] Move filter_parameter_logging logic into ActionDispatch::ParametersFilter

#3763

I was going to implement a feature to filter request_uri, and found out that filter_parameter_logging is defined in controller instead. So I write this patch to move the logic into ActionDispatch:: ParametersFilter, which is included in ActionDispatch::Request

I also saw this commit http://github.com/rails/rails/commit/87bcf1aa15f8edb4287e1916b65a2c... implements filter_env, so I'm implementing it in ActionDispatch::ParametersFilter also.

I've separate the patch into two parts: one is the ActionDispatch::ParametersFilter itself, and the other one is deprecation of filter_parameter_logging in controller. I think the configuration should be moved to Rails.configuration instead.

Reported by Prem Sichanugrist (sikachu) · January 21st, 2010 @ 04:50 AM

State: resolved
Milestone: 3.0.2
Assigned to: José Valim José Valim
Importance: Medium

Activity

  1. Prem Sichanugrist (sikachu)
    Prem Sichanugrist (sikachu)
    • Tag changed from 3.0, actioncontroller, actiondispatch, patch to 3.0, actioncontroller, actiondispatch, patch, review

    January 21st, 2010 @ 10:16 AM

  2. José Valim
    José Valim
    • State changed from open to resolved

    January 21st, 2010 @ 12:21 PM

  3. Jeremy Kemper
    Jeremy Kemper
    • Milestone set to 3.0.2
    • Importance changed from to Medium

    October 15th, 2010 @ 11:01 PM