This project is archived and is in readonly mode.
[PATCH] Move filter_parameter_logging logic into ActionDispatch::ParametersFilter
Reported by Prem Sichanugrist (sikachu) | January 21st, 2010 @ 04:50 AM | in 3.0.2
I was going to implement a feature to filter
request_uri, and found out that
filter_parameter_logging is defined in controller
instead. So I write this patch to move the logic into
ActionDispatch:: ParametersFilter, which is included
in ActionDispatch::Request
I also saw this commit
http://github.com/rails/rails/commit/87bcf1aa15f8edb4287e1916b65a2c...
implements filter_env, so I'm implementing it in
ActionDispatch::ParametersFilter also.
I've separate the patch into two parts: one is the
ActionDispatch::ParametersFilter itself, and the other
one is deprecation of filter_parameter_logging in
controller. I think the configuration should be moved to
Rails.configuration instead.
Comments and changes to this ticket
-
Prem Sichanugrist (sikachu) January 21st, 2010 @ 10:16 AM
- Tag changed from “3.0, actioncontroller, actiondispatch, patch” to “3.0, actioncontroller, actiondispatch, patch, review”
-
José Valim January 21st, 2010 @ 12:21 PM
- State changed from “open” to “resolved”
-
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
- Importance changed from “” to “Medium”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
José Valim
Prem Sichanugrist (sikachu)