This project is archived and is in readonly mode.
Redundant ActionMailer test code supposedly added to fix a very old Mocha bug
Reported by James Mead | February 7th, 2010 @ 07:08 PM
In commit 704f2cc6dee9d55d19bfad8e4a8308fdee71bf6f a couple of lines of code were adding with the following comment: "Replacing logger work around for mocha bug. Should be fixed in mocha 0.3.3".
Since the Rails Gemfile now specifies Mocha >= 0.9.8 and since the ActionMailer tests still pass when these lines are removed, it seems sensible to remove them.
Comments and changes to this ticket
-
Rohit Arondekar October 8th, 2010 @ 02:24 AM
- State changed from “new” to “open”
- Assigned user set to “Santiago Pastorino”
- Importance changed from “” to “Low”
That patch doesn't apply any more. Here is a new one. The tests still pass after removing the workaround.
-
Santiago Pastorino October 8th, 2010 @ 11:35 AM
Well done Rohit, you're tackling every issue at LH. But can you please keep the author in this one?.
I guess James can be unhappy if we change it ;). -
-
Repository October 8th, 2010 @ 06:34 PM
- State changed from “open” to “committed”
(from [f415b3e6d18f0e018e08f2af8e19e40ac93a8524]) Remove old workaround for mocha bug. [#3886 state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/f415b3e6d18f0e018e08f2af8e19e4... -
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
James Mead
Jeremy Kemper
Rohit Arondekar
Ryan Bigg
Attachments
Referenced by
-
3886
Redundant ActionMailer test code supposedly added to fix a very old Mocha bug
(from [f415b3e6d18f0e018e08f2af8e19e40ac93a8524])
Remove ...