This project is archived and is in readonly mode.
Redundant ActionMailer test code supposedly added to fix a very old Mocha bug
In commit 704f2cc6dee9d55d19bfad8e4a8308fdee71bf6f a couple of lines of code were adding with the following comment: "Replacing logger work around for mocha bug. Should be fixed in mocha 0.3.3".
Since the Rails Gemfile now specifies Mocha >= 0.9.8 and since the ActionMailer tests still pass when these lines are removed, it seems sensible to remove them.
-
Rohit Arondekar- State changed from new to open
- Assigned user set to Santiago Pastorino
- Importance changed from to Low
That patch doesn't apply any more. Here is a new one. The tests still pass after removing the workaround.
-
remove_old_code.diff
1.16 KB
-
Santiago PastorinoWell done Rohit, you're tackling every issue at LH. But can you please keep the author in this one?.
I guess James can be unhappy if we change it ;). -
-
Repository
- State changed from open to committed
(from [f415b3e6d18f0e018e08f2af8e19e40ac93a8524]) Remove old workaround for mocha bug. [#3886 Redundant ActionMailer test code supposedly added to fix a very old Mocha bug state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/f415b3e6d18f0e018e08f2af8e19e4... -
