verify with render[:layout] and cache_classes broken

With configuration option

  config.cache_classes = true

will a controller's verify with specified render[:layout] use this layout only once, the second time this verify block renders is going to be used the default layout for the controller.

Example:

1) set

  config.cache_classes = true

2) add to your controller

  verify(:only => ['test'], :params => :foo, :render => {:template => 'bar/baz', :layout => 'lay0'})
  layout 'lay1'

3) setup different layouts lay0, lay1
4) request the test action twice in a row from the server and see, what is being rendered

The first time it will render the lay0 layout, second and all other times it will render the defaul layout lay1.

It's because the code in actionpack/lib/action_controller/layout.rb:

    def pick_layout(options)
    if options.has_key?(:layout)
      case layout = options.delete(:layout)
      when FalseClass
        nil
      when NilClass, TrueClass

-- note the "options.delete(:layout)".

You can get a picture what's going on if you freeze the render hash in actionpack/lib/action_controller/verification.rb:

    --- verification.rb.orig        2010-02-15 16:34:33.000000000 +0100

+++ verification.rb     2010-02-15 18:15:23.000000000 +0100
@@ -80,6 +80,7 @@
       #   array (may also be a single value).
       def verify(options={})
         before_filter :only => options[:only], :except => options[:except] do |c|
+          options[:render].freeze if options[:render]
           c.__send__ :verify_action, options
         end
       end

Workaround: instad of

  verify(:only => ['test'], :params => :foo, :render => {:template => 'bar/baz', :layout => 'lay0'})

use:

    before_filter :verify_foo, :only => ['test']

private

def verify_foo
  verify_action({:params => :foo, :render => {:template => 'bar/baz', :layout => 'lay0'}})
end</code>

One of the possible solutions is passing on a deep copy of the options passed to verify (see the attached patch).