#3976 Better style in NumberHelper - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#3976 ✓resolved

Better style in NumberHelper

Reported by Xavier Shay | February 17th, 2010 @ 04:12 AM | in 3.0.2

NumberHelper uses blank rescues heap, this is pretty bad form and makes the code harder to understand. I refactored out the obvious abuses, though left in the ones on the i18n translate lines since I figure that pattern (which I don't like) is probably used elsewhere.

This doesn't change tested behaviour.

0001-remove-some-of-the-blank-rescues-from-number-helper.patch 6 KB

Comments and changes to this ticket

You flagged this item as spam.
John February 17th, 2010 @ 04:27 AM
I just gave the patch a good readthrough, much neater.

+1
Santiago Pastorino March 4th, 2010 @ 08:49 PM
- Tag changed from “actionpack numberhelper style” to “actionpack numberhelper style, 3.0”
- Assigned user set to “Yehuda Katz (wycats)”
- Milestone cleared.
Applies cleanly on master
Santiago Pastorino March 5th, 2010 @ 05:15 PM
- State changed from “new” to “resolved”
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
- Importance changed from “” to “Low”
[bulk edit]