Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Better style in NumberHelper

#3976

NumberHelper uses blank rescues heap, this is pretty bad form and makes the code harder to understand. I refactored out the obvious abuses, though left in the ones on the i18n translate lines since I figure that pattern (which I don't like) is probably used elsewhere.

This doesn't change tested behaviour.

Reported by Xavier Shay · February 17th, 2010 @ 04:12 AM

State: resolved
Milestone: 3.0.2
Assigned to: Yehuda Katz (wycats) Yehuda Katz (wycats)
Importance: Low

Activity

  1. John
    John

    I just gave the patch a good readthrough, much neater.

    +1

    February 17th, 2010 @ 04:27 AM

  2. Santiago Pastorino
    Santiago Pastorino
    • Tag changed from actionpack numberhelper style to actionpack numberhelper style, 3.0
    • Assigned user set to Yehuda Katz (wycats)
    • Milestone cleared.

    Applies cleanly on master

    March 4th, 2010 @ 08:49 PM

  3. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to resolved

    March 5th, 2010 @ 05:15 PM

  4. Jeremy Kemper
    Jeremy Kemper
    • Milestone set to 3.0.2
    • Importance changed from to Low

    October 15th, 2010 @ 11:01 PM