This project is archived and is in readonly mode.

#4133 ✓invalid
Marc Schütz

browser compatibility changes for prototype-ujs

Reported by Marc Schütz | March 8th, 2010 @ 07:47 PM | in 3.0.2

The attached patch works around the following problems in the prototype rails.js:

  • Element.findElement("a[data-remote]") etc. didn't work in Konqueror. It seems not to return; didn't investigate further. My workaround is to check whether the current element is a anchor and has data-xxx set. This makes more sense anyway, because I cannot think of a use case where we would take the url of a parent element instead of the one that triggered the click event.
  • The submit event doesn't bubble in IE (as was already noted in a comment). I've worked around this by observing the click event of the form's submit button instead (which is also fired when the button is pressed via keyboard).

Tested in FF 3.6, Konqueror 4.4.0, IE 8 (normal and in compat mode).

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Referenced by

Pages