#4133 browser compatibility changes for prototype-ujs - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4133 ✓invalid

browser compatibility changes for prototype-ujs

Reported by Marc Schütz | March 8th, 2010 @ 07:47 PM | in 3.0.2

The attached patch works around the following problems in the prototype rails.js:

Element.findElement("a[data-remote]") etc. didn't work in Konqueror. It seems not to return; didn't investigate further. My workaround is to check whether the current element is a anchor and has data-xxx set. This makes more sense anyway, because I cannot think of a use case where we would take the url of a parent element instead of the one that triggered the click event.
The submit event doesn't bubble in IE (as was already noted in a comment). I've worked around this by observing the click event of the form's submit button instead (which is also fired when the button is pressed via keyboard).

Tested in FF 3.6, Konqueror 4.4.0, IE 8 (normal and in compat mode).

You flagged this item as spam.
Marc Schütz March 12th, 2010 @ 10:15 AM
See also #4114.
You flagged this item as spam.
Marc Schütz March 12th, 2010 @ 10:21 AM
Updated patch to make link_to with images work, as suggested by Robs in #4156.
You flagged this item as spam.
Marc Schütz March 12th, 2010 @ 11:33 AM
As regards Konquerors inability to cope with Element.findElement("xxx"), it doesn't work in Konqueror 3.5.9, but it does work in Konqueror 4.4.1. So I removed the changes for Konqueror again.

New patches tested in FF 3.6, Konqueror 4.4.1, IE 6 and IE 8 (normal and compat).
- rails.js 4.5 KB
- prototype-ujs-browser-compat.patch 3.2 KB
Jeremy Kemper March 12th, 2010 @ 06:33 PM
- State changed from “new” to “open”
- Assigned user set to “josh”
- Milestone cleared.
josh March 12th, 2010 @ 06:40 PM
- State changed from “open” to “invalid”
The new css selector stuff requires edge prototype.
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
- Importance changed from “” to “Low”
[bulk edit]

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>