Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

ActiveModel::Dirty#changes should return a HashWithIndifferentAccess

#4157

I've been bitten by the fact that #changes currently returns a plain Ruby hash instead of a HashWithIndifferentAccess. To keep things consistent I've created a patch that changes this.

Reported by Jacob Atzen · March 12th, 2010 @ 09:38 AM

State: resolved
Milestone: 3.0.2
Assigned to: José Valim José Valim
Importance: Low

Activity

  1. Jacob Atzen
    Jacob Atzen
    • Tag changed from activemodel to activemodel, patch

    March 12th, 2010 @ 09:43 AM

  2. Jacob Atzen
    Jacob Atzen

    New smaller patch based on feedback from Radar.

    March 12th, 2010 @ 10:36 AM

  3. Jacob Atzen
    Jacob Atzen

    New smaller patch based on feedback from Radar.

    March 12th, 2010 @ 10:38 AM

  4. Yehuda Katz (wycats)
    Yehuda Katz (wycats)
    • Assigned user set to José Valim
    • Milestone cleared.

    March 27th, 2010 @ 09:27 AM

  5. Repository
    Repository
    • State changed from new to resolved

    (from [a5d637d86c02d911b07d48bdbfbc4f23fb59d720]) ActiveModel::Dirty#changes should return a HashWithIndifferentAccess [#4157 ActiveModel::Dirty#changes should return a HashWithIndifferentAccess state:resolved]

    Keep the Rails style of inject

    Signed-off-by: José Valim jose.valim@gmail.com
    http://github.com/rails/rails/commit/a5d637d86c02d911b07d48bdbfbc4f...

    March 27th, 2010 @ 10:07 AM

  6. Jeremy Kemper
    Jeremy Kemper
    • Milestone set to 3.0.2
    • Importance changed from to Low

    October 15th, 2010 @ 11:01 PM