ActiveResource::Base.save (PUT) doesn't clear out errors

Sorry, was fighting LH there for a sec, here is the patch

-1

Looks like it still have some issues. See pastie http://pastie.org/962508

after setting

a.name = nil
a.valid? should return false. But it's returning true.

Hi Anil,

valid? on AResource works differently than ARecrod. In ARecord you can check against the validations, but in AResource you need to post again as validations are on the server. save is the only way to run the validations again, which this patch corrects (clearing errors before save).

What you are asking for is not supported in AResource.

Josh

Sorry, I didn't add before that the original bug is verified

applies cleanly and tests pass for 1.8.7, but tests do not pass for 1.8.6 so I can't give a plus one.

I don't think it has to do with this pathch though. This is the error I get:

  1) Error:
test_exists_without_http_mock(BaseTest):
NoMethodError: undefined method `any_instance' for ActiveResource::Connection:Class
    ./test/base_test.rb:989:in `test_exists_without_http_mock'

  2) Error:
test_accept_http_header(ConnectionTest):
NoMethodError: undefined method `mock' for #<ConnectionTest:0xb78ae2a8>
    ./test/connection_test.rb:203:in `test_accept_http_header'

  3) Error:
test_ssl_error(ConnectionTest):
NoMethodError: undefined method `expects' for #<ActiveResource::Connection:0xb7bb7a1c>
    ./test/connection_test.rb:223:in `test_ssl_error'

  4) Error:
test_timeout(ConnectionTest):
NoMethodError: undefined method `mock' for #<ConnectionTest:0xb78adf74>
    ./test/connection_test.rb:185:in `test_timeout'

162 tests, 501 assertions, 0 failures, 4 errors

Code looks good too. One thing though, i think the test should be as follows

[ :json, :xml ].each do |format|
  def test_should_clear_errors_when_error_is_corrected
    set_mocks_to_invalid
    invalid_user_using_format(format) do
      assert !@person.valid?

      @person.name = "Joe Shmoe"
      @person.age  = 56

      set_mocks_to_valid

      assert @person.save
      assert @person.valid?
    end
  end
end

This way the tests for xml and json fail seperately if ever.

sorry, i get those errors without this patch too. Anyone else?

Here is the improved example http://gist.github.com/403156

Is anyone able to verify and comment on this patch?

+1

I can still repro this issue in Rails3

Automatic cleanup of spam.

Automatic cleanup of spam.

louis vuitton watches