Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Jeroen van Dijk's latest activity

Sunday, May 16 2010
4621 Errors in test suite under 1.8.6-p399 related to Mocha? was created in Ruby on Rails
  • Jeroen van Dijk
    Jeroen van Dijk created the ticket at 10:00 PM

    I get the following errors when running under 1.8.6

    
      1) Error:
    test_exists_without_http_mock(BaseTest):
    NoMethodError: undefined method `any_instance' for Ac...
4169 ActiveResource::Base.save (PUT) doesn't clear out errors was updated in Ruby on Rails
  • Jeroen van Dijk
    Jeroen van Dijk commented at 9:50 PM

    Here is the improved example http://gist.github.com/403156

  • Jeroen van Dijk
    Jeroen van Dijk commented at 9:44 PM

    sorry, i get those errors without this patch too. Anyone else?

  • Jeroen van Dijk
    Jeroen van Dijk commented at 9:42 PM

    applies cleanly and tests pass for 1.8.7, but tests do not pass for 1.8.6 so I can't give a plus one.

    I don't think it has to do with this pathch though. This i...

4057 Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ha... was updated in Ruby on Rails
  • Jeroen van Dijk
    • Tag changed from activemodel, messages, validation to activemodel, bugmash-review, messages, validation
    by Jeroen van Dijk at 9:23 PM

    Here is my latest patch. I have done a lot of refactoring in the tests to make sure things aren't repeated all over the place.

    Each validators cleans it on own ...

  • Jeroen van Dijk
    Jeroen van Dijk commented at 3:43 PM

    The goal of the commit was to make the validations more flexible. The whitelist approach was an intermediate solution to satisfy the strict tests. My plan was t...

Saturday, May 15 2010
4607 I18n ActiveModel Subclass Lookup was updated in Ruby on Rails
  • Jeroen van Dijk
    Jeroen van Dijk commented at 11:33 PM

    It is not a bug, but I do think that the following is more appropriate though:

    activemodel:
      errors:
        models:
          conversation:
            message:
            ...
4057 Make ActiveModel::Errors#add_on_blank and #add_on_empty accept an options ha... was updated in Ruby on Rails
  • Jeroen van Dijk
    Jeroen van Dijk commented at 6:53 PM

    I forgot the patch...

  • Jeroen van Dijk
    Jeroen van Dijk commented at 6:53 PM

    I have adapted the patch so that it applies on master, some small cleanups here and there.

    The filtering is currently needed, because the tests in i18n_generate...

4537 Add method to get to content captured with content_for from helper methods was updated in Ruby on Rails