This project is archived and is in readonly mode.

#4232 ✓committed
Xavier Noria

adds missing require, and cleans a bit #compute_public_path

Reported by Xavier Noria | March 19th, 2010 @ 12:55 PM

compute_public_path asks is_uri?(source) a few times to avoid touching explicit URLs. This refactor moves that condition to the top to make this more obvious. Also, it cleans the method a bit now that we are on it.

I think it reads better with this patch.

Moreover, asset_tag_helper.rb uses present? and blank? in a few spots, but the corresponding require is missing.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Attachments

Referenced by

Pages