This project is archived and is in readonly mode.
[PATCH] assert_recognizes should work in Integration Tests
-
MatthewRudy
- Assigned user set to Santiago Pastorino
I don't know if this is the right answer...
but...
it broke my tests..Like I say,
perhaps the answer is not to include these assertions
but as it stands the assertions exist
but will not work
unless we do the
ourselves in the integration test.setup do @routes = :blah endAlternatively
we could add an exception
explaining this hack
to the assertion -
Santiago Pastorino
- State changed from new to invalid
assert_recognizes doesn't make sense on an IntegrationTest use it in Functional tests
-
Santiago Pastorino
- State changed from invalid to open
Perhaps it's not the best use case but should work. Need more discussion here
-
MatthewRudy
I agree it may not make sense,
but it seems wrong that the method is included,
but is guaranteed to break.I've got another fix in my head
give me a mo,
I'll attach another patch. -
Santiago Pastorino
- Milestone cleared.
Matthew Rudy I have a solution but i'll wait i want to apply yours ;)
-
MatthewRudy
sorry Santiago
I am in Taipei,
didnt have internet to upload my patch.I'd like to see you solution,
but here's minebasically I decided that the line in the assertion which assumes "@routes" is set
can just throw an exception if its not
and suggest adding the @routes = ...attached as a patch
and on githubhttp://github.com/matthewrudy/rude-rails/commit/c333d0bea336f1ecf8a...
http://github.com/matthewrudy/rude-rails/tree/make-assert-recognise... -
Santiago Pastorino
- Assigned user changed from Santiago Pastorino to Jeremy Kemper
MatthewRudy here is the fix, i've made with your name ;) http://github.com/spastorino/rails/commit/ed1aa8e0bd33480cb2d10942d... and here are the tests http://github.com/spastorino/rails/commit/7e5e9338a6e9f85df1506c843...
Let's wait for Jeremy revision.
Thank you!. -
Repository
- State changed from open to committed
(from [5c9d23f870bc59a42a2c5994f4e6b11d3e4e5bdc]) Make assert_recognizes work in IntegrationTest [#4390 [PATCH] assert_recognizes should work in Integration Tests state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/5c9d23f870bc59a42a2c5994f4e6b1... -
Repository
(from [ed0ca5db9ea247ceae67f22a750cbd49006f35ed]) Add a test for assert_recognizes on ActionDispatch::IntegrationTest [#4390 [PATCH] assert_recognizes should work in Integration Tests state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/ed0ca5db9ea247ceae67f22a750cbd...
