Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Builder templates should respect mimetypes matching format parameter

#444

What I did:

I added the mimetype "application/vnd.google-earth.kml+xml" mapped to extension .kml, and created a view show.kml.builder

What should happen:

Requests to /show.kml should use the show.kml.builder view, with the response type set to "application/vnd.google-earth.kml+xml"

What does happen:

Requests to /show.kml do use the show.kml.builder view, but the response type is set to "application/xml"

I will look into the best way to fix this evening

Reported by Tom Ward · June 18th, 2008 @ 07:36 AM

State: resolved
Milestone: none
Assigned to: josh josh
Importance: none

Activity

  1. Tom Ward
    Tom Ward

    FYI: action_view/template_handlers/builder.rb sets the mimetype to XML if it hasn't been set beforehand

    June 18th, 2008 @ 04:15 PM

  2. Pratik
    Pratik
    • Assigned user set to josh
    • Tag set to actionpack

    July 18th, 2008 @ 07:04 PM

  3. Tom Ward
    Tom Ward

    I'm working on a fix for this right now. Would have claimed it myself, but can't set anyone other than core team as responsible.

    July 18th, 2008 @ 07:38 PM

  4. Tom Ward
    Tom Ward

    July 18th, 2008 @ 08:25 PM

  5. Tom Ward
    Tom Ward
    • Tag changed from actionpack to actionpack, patch, tiny

    Added patch

    July 18th, 2008 @ 08:25 PM

  6. josh
    josh

    This looks good, we should definitely force a content type instead of reverting to html.

    July 19th, 2008 @ 01:47 AM

  7. Repository
    Repository
    • State changed from new to resolved

    (from [c3d1fda555c4bd5f8821d830c685ae5d0e7e52d0]) Set the response content type to that of found template if not explicitly set elsewhere [#444 state:resolved]

    Signed-off-by: Joshua Peek

    http://github.com/rails/rails/co...

    July 19th, 2008 @ 02:16 AM