This project is archived and is in readonly mode.
Rails 3.0 encoding fixes for unit tests
Reported by Cezary Baginski | April 25th, 2010 @ 06:45 PM | in 3.0.2
I'm trying to get Rails 3.0 tests to work with any combination of Ruby (1.8.7, 1.9.1, ruby-head) and Ruby standard encoding (-Ku -Kn -Ks -Ke and no option).
The possibility to run any such combination will help Rails encoding support by:
- testing for encoding correctness without the need for more test cases
- helping find missing encoding comments in source files
- detecting bad encoding assumptions, etc.
- preventing encoding regressions unnoticeable otherwise
- helping users create more robust and helpful patches
Comments and changes to this ticket
-
Cezary Baginski April 25th, 2010 @ 06:54 PM
The following patch for actionpack contains:
- Ruby 1.8.7 -Ke/-Ks interpretable UTF-8 string
- Ruby 1.9.1-p378 symbol lookup workaround
- UTF-8 regex for Ruby 1.8.7 -Ke/-Ks
-
Cezary Baginski April 26th, 2010 @ 12:12 AM
As for activesupport:
ruby 1.9.1p378 (r26273) is too old to run the unit tests, because of the bug in the String methods (rjust, ljust, center, etc).
The minimal rev seems to be: r26568, which fixes this.
1.9.1-head works (1.9.1p420), not mentioning a tiny patch is needed.
-
Repository April 26th, 2010 @ 01:09 AM
- State changed from “new” to “committed”
(from [490a3335d56c124c8113aac0b63ad367f81bb450]) Action Pack: fix tests with -K*, work around Ruby 1.9.1 constant lookup.
[#4473 state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/490a3335d56c124c8113aac0b63ad3... -
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
- Importance changed from “” to “Low”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Cezary Baginski
Attachments
Tags
Referenced by
-
4473
Rails 3.0 encoding fixes for unit tests
[#4473 state:committed]