ActiveResource does not serialize XML correctly

Even Rails beta 3 is working fine. Problem is in the edge version.

I introduced a major change the way to_xml works a week back. Looks like that commit is causing the error. Looking into this issue.

On further analysis the commit that is causing this problem is this one.

http://github.com/rails/rails/commit/7cd1d37a51f5f53f8fc1360f886d26...

Pastorino, your patch is changing the cached values. This means that every time I call human, it's going to execute this line:

ActiveSupport::Inflector.humanize(@element).freeze

And you should change the @human value if the @element changes. Consider this case:

class Post < ActiveResource::Base
  self.element_name = "api-post"
end

Post.model_name.human #=> "Post"

You should also cache the collection using "@collection ||=".

Caching the result would still work for collection when you set it through self.collection_name

Hehehe, yes you're right. Perhaps i need to go bed :).
New patch here.

ActiveModel::Name isn't meant to be a mutable object, though. You could set and cache these on the instance itself, or instantiate and cache a new Name with updated values.

Ok i will redo with this in mind ;)

Take a look now Jeremy, thanks.

patch here

With the new changes

As Jeremy requested ;), thanks Jeremy

Pending tests for ActiveModel::Name changes.

I hope now the patch is ok

Setting a custom collection name is not preserved:

name.collection = 'foo'
name.element = 'bar'
assert_equal 'foo', name.collection  # but it returns 'bars'

Also, this is unneeded

-    attr_reader :singular, :plural, :element, :collection, :partial_path
-    alias_method :cache_key, :collection
+    attr_reader   :singular, :plural, :partial_path
+    attr_accessor :element, :collection
+    alias_method  :cache_key, :collection

Case fixed and more tests added

Jeremy, I leave here the another possibility we discussed

Jeremy I've uploaded again the two patches the first i leave as it was and the second one i've fixed a bit to cache partial_path.
Please tell me if this need something more to be done.

(from [bea3c26833ad3e1e94f7331e0553a4e2164e7de5]) Make ActiveResource serialize XML correctly when element_name is set.

[#4529 ActiveResource does not serialize XML correctly]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/bea3c26833ad3e1e94f7331e0553a4...

Jeremy backport of tests http://github.com/spastorino/rails/commit/6267187f3c2c703cb1f1dcb1b... but nothing broke on 2-3-stable

(from [c4ef7bb2a0a2e2351f5ed2b1f98c9b40c441591e]) to_json and to_xml tests added to ActiveResource

[#4529 ActiveResource does not serialize XML correctly state:resolved]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/c4ef7bb2a0a2e2351f5ed2b1f98c9b...

This changeset includes a regression or an intentional change that should be documented.

module Foo
  class Bar < ActiveResource::Base
  end
end

Before the changeset, this would requests the url /bars
After the changeset, this now requests the url /foo/bars

A better one ;)