.select and :select in AR does not work correctly with an array

Attached is a patch against rails3 edge.

@Josh thanks for the failing test.

Current code is given below.

# query_methods.rb
selects = @select_values.uniq
if selects.present?
  selects.each do |s|
    @implicit_readonly = false
    arel = arel.project(s) if s.present?
  end
else
  arel = arel.project(quoted_table_name + '.*')
end

As you can see for each select column arel.project(s) is being called. However multiple project is specified on arel then the last one wins.

Take a look at this test.

users = Table(:users)
users.project(users[:email]).project(users[:phone]).to_sql
"SELECT     \"users\".\"phone\" FROM       \"users\""

The correct way to handle this would be.

users.project(users[:email],users[:phone]).to_sql
"SELECT     \"users\".\"email\", \"users\".\"phone\" FROM       \"users\""

Attached patch provides the all the columns names to get selected columns.

Hi Neeraj Singh,

Can you update the ticket as verified. Also, have the run all the AR tests?

Thanks

Josh

@Santiago Thanks for the much better fix. Now I know better. :-)

This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.