This project is archived and is in readonly mode.
config.cache_classes = false is broken in 2.3.4 and 2.3.5
-
Michael Koziarski
- Milestone set to 2.3.6
- Tag changed from cache_classes, thread to bugmash, cache_classes, thread
- State changed from new to verified
- Title changed from config.cache_classes = false is broken in 2.3.4 and 2.3.5 to Integration Test runner doesn't call #close on the response body
The issue here is that the integration test runner doesn't call close on the body, thereby leaving the reloader mutex locked.
-
Jarl Friis
- Tag changed from bugmash, cache_classes, thread to cache_classes, thread
- Title changed from Integration Test runner doesn't call #close on the response body to config.cache_classes = false is broken in 2.3.4 and 2.3.5
Ticket #3153 may be related to this ticket.
-
Jarl Friis
- Tag changed from cache_classes, thread to bugmash, cache_classes, thread
Oops I didn't intend to change neither title nor tags, it must have been because I updated a not-updated ticket. I don't know how to change the title back again.
-
Neeraj Singh
- Tag changed from bugmash, cache_classes, thread to bugmash, cache_classes, patch, thread
Attached is code patch.
Providing a test for the patch is really difficult because all the existing integration_test mock the actual call.
-
Rizwan Reza
- Tag changed from bugmash, cache_classes, patch, thread to bugmash-review, cache_classes, patch, thread
-
Rizwan Reza
+1 verified
The patch seems to be a simple and applies cleanly. All tests pass.
-
Rizwan Reza
- Tag changed from bugmash-review, cache_classes, patch, thread to bugmash, bugmash-review, cache_classes, patch, thread
-
Repository
- State changed from verified to resolved
(from [3570f3e7f692e1d43e6be4d65bc6de986748cab8]) Fix broken integration test in 2.x [#4565 config.cache_classes = false is broken in 2.3.4 and 2.3.5 state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/3570f3e7f692e1d43e6be4d65bc6de... -
Rizwan Reza
- Tag changed from bugmash, bugmash-review, cache_classes, patch, thread to bugmash, cache_classes, patch, thread
