This project is archived and is in readonly mode.
Test suite is using assert many times when should be used assert_equal
-
Santiago Pastorino
- Tag changed from bugmash, testing to bugmash, bugmash-review, patch, testing
-
Santiago Pastorino
One more added
-
Rizwan Reza
- Tag changed from bugmash, bugmash-review, patch, testing to bugmash, patch, testing
Can someone test and report back before we hand it over to core for review?
-
PacoGuzman
+1
Patch applies clean in rails edge. All test pass.
Maybe should be usefull use in all the test the same expression with the '!' character, so:
assert ! content_for?(:title)
Would write like:
assert !content_for?(:title)
For all the test suite, or maybe this is useless, what do you think?
-
Bastes
+1
Applies to rails edge, all test pass.
Does not apply to 2-3-stable though :
error: patch failed: activesupport/test/caching_test.rb:375
error: activesupport/test/caching_test.rb: patch does not apply
-
Rohit Arondekar
+1 Applies to rails edge and the tests pass. Just one thing though, a few of those (the ones from action pack) are repeating the ones I cleared in http://github.com/rails/rails/commit/fc2480a277fd4753aebf68dcf8787d...
-
Santiago Pastorino
Some of the things i did were applied on others tickets, so i deleted the repeated ones.
-
Bastes
Looks like it's already been applied (no changes when I patch on both master and 2-3-stable).
-
Repository
- State changed from open to committed
(from [fdfebb7782a399839ac9a9e63d5153565d6f88f4]) Make use of assert_equal to test equallity between object assert expects and object and a message of error
[#4611 Test suite is using assert many times when should be used assert_equal state:committed]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/fdfebb7782a399839ac9a9e63d5153... -
Rizwan Reza
- Tag changed from bugmash, patch, testing to patch, testing
