This project is archived and is in readonly mode.
Test suite is using assert many times when should be used assert_equal
Reported by Santiago Pastorino | May 16th, 2010 @ 05:33 AM | in 3.0.2
Apart from the fact that this doesn't test anything but the object in question is not nil, break the tests on 1.9.2.
Comments and changes to this ticket
-
Santiago Pastorino May 16th, 2010 @ 05:37 AM
- Tag changed from bugmash, testing to bugmash, bugmash-review, patch, testing
-
Rizwan Reza May 16th, 2010 @ 09:31 AM
- Tag changed from bugmash, bugmash-review, patch, testing to bugmash, patch, testing
Can someone test and report back before we hand it over to core for review?
-
PacoGuzman May 16th, 2010 @ 12:35 PM
+1
Patch applies clean in rails edge. All test pass.
Maybe should be usefull use in all the test the same expression with the '!' character, so:
assert ! content_for?(:title)
Would write like:
assert !content_for?(:title)
For all the test suite, or maybe this is useless, what do you think?
-
Bastes May 16th, 2010 @ 01:59 PM
+1
Applies to rails edge, all test pass.
Does not apply to 2-3-stable though :
error: patch failed: activesupport/test/caching_test.rb:375
error: activesupport/test/caching_test.rb: patch does not apply
-
Rohit Arondekar May 16th, 2010 @ 02:25 PM
+1 Applies to rails edge and the tests pass. Just one thing though, a few of those (the ones from action pack) are repeating the ones I cleared in http://github.com/rails/rails/commit/fc2480a277fd4753aebf68dcf8787d...
-
Santiago Pastorino May 16th, 2010 @ 02:39 PM
Some of the things i did were applied on others tickets, so i deleted the repeated ones.
-
Bastes May 16th, 2010 @ 03:08 PM
Looks like it's already been applied (no changes when I patch on both master and 2-3-stable).
-
Repository May 16th, 2010 @ 03:16 PM
- State changed from open to committed
(from [fdfebb7782a399839ac9a9e63d5153565d6f88f4]) Make use of assert_equal to test equallity between object assert expects and object and a message of error
[#4611 state:committed]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/fdfebb7782a399839ac9a9e63d5153... -
Rizwan Reza May 16th, 2010 @ 03:57 PM
- Tag changed from bugmash, patch, testing to patch, testing
-
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to 3.0.2
- Importance changed from to Low
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Referenced by
- 4611 Test suite is using assert many times when should be used assert_equal [#4611 state:committed]