This project is archived and is in readonly mode.
Use Rack::Utils.bytesize instead of #length when determining request content-length for showing exceptions.
-
Norman Clarke
Do we need to use Rack::Utils.bytesize? for this? Since Rails 3 now only supports 1.8.7 or higher, I think we can just use String#bytesize. I think that method is in Rack::Utils just to support 1.8.6.
-
tarsolya
Good point. You are right. Attached the modified patchfile.
Thanks.
-
Norman Clarke
+1 Looks good to me.
-
Balint Erdi
+1
-
Gabor Ratky
+1
-
LacKac
+1
-
Michael Koziarski
- Milestone cleared.
-
Santiago Pastorino
- Milestone cleared.
- State changed from new to open
- Assigned user set to José Valim
-
Repository
- State changed from open to resolved
(from [bb6cd6d3ec02996c7dd11a4bb96381da18b7de8a]) Use Rack::Utils.bytesize when calculating content-length of exception pages. [#4727 Use Rack::Utils.bytesize instead of #length when determining request content-... state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/bb6cd6d3ec02996c7dd11a4bb96381...
