#481 Route optimisation adds hanging question mark when passed empty options hash - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#481 ✓committed

Route optimisation adds hanging question mark when passed empty options hash

Reported by Luke Melia | June 25th, 2008 @ 04:05 AM

From a view, when calling something like

widget_path(5, {})

you get

/widgets/5?

but I want

/widgets/5

Attached is a patch that fixes the problem, but I haven't been able to figure out how to write a test for it. The test in the patch doesn't actually test the optimisation code -- it just verifies that the unoptimized version does not add the question mark.

route_optimization_fix.patch 2.1 KB

Comments and changes to this ticket

Pratik June 27th, 2008 @ 01:53 PM
- Tag set to “actionpack, bug, edge, patch”
- Assigned user set to “Michael Koziarski”
Repository August 31st, 2008 @ 06:42 PM
- State changed from “new” to “committed”
(from [7ce03db77884e21256ba8f1615ad8dd841b76b86]) Fixes optimised named routes generating question mark followed by nothing when provided an empty hash as the last argument.

Signed-off-by: Michael Koziarski michael@koziarski.com [#481 state:committed] http://github.com/rails/rails/co...