This project is archived and is in readonly mode.
Route optimisation adds hanging question mark when passed empty options hash
From a view, when calling something like
widget_path(5, {})
you get
/widgets/5?
but I want
/widgets/5
Attached is a patch that fixes the problem, but I haven't been able to figure out how to write a test for it. The test in the patch doesn't actually test the optimisation code -- it just verifies that the unoptimized version does not add the question mark.
-
route_optimization_fix.patch
2.12 KB
-
Pratik- Tag set to actionpack, bug, edge, patch
- Assigned user set to Michael Koziarski
-
Repository- State changed from new to committed
(from [7ce03db77884e21256ba8f1615ad8dd841b76b86]) Fixes optimised named routes generating question mark followed by nothing when provided an empty hash as the last argument.
Signed-off-by: Michael Koziarski michael@koziarski.com [#481 Route optimisation adds hanging question mark when passed empty options hash state:committed] http://github.com/rails/rails/co...