Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

habtm _ids association with non numeric ids no longer allowed

#4813

Hi,

The pasted code (around line 1337 of lib /active_record/associations.rb in activerecord-2.3.8) prevents the usage of non numeric ids (which afaik is perfectly legal and used to work with previous version of AR) when doing the following: Foo.new(:name => 'foobar' :friend_ids => ["non_numeric_id"])

define_method("#{reflection.name.to_s.singularize}_ids=") do |new_value|
ids = (new_value || []).reject { |nid| nid.blank? }.map(&:to_i) send("#{reflection.name}=", reflection.klass.find(ids).index_by(&:id).values_at(*ids)) end

I think it's something that should be fixed. Otherwise advice is appreciated.

Thanks

Reported by lcars · June 9th, 2010 @ 06:13 PM

State: stale
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 04:37 PM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 04:37 PM

  3. Dmitry Polushkin
    Dmitry Polushkin

    I guess it now possible in Rails3.

            redefine_method("#{reflection.name.to_s.singularize}_ids=") do |new_value|
          pk_column = reflection.primary_key_column
          ids = (new_value || []).reject { |nid| nid.blank? }
          ids.map!{ |i| pk_column.type_cast(i) }
          send("#{reflection.name}=", reflection.klass.find(ids).index_by{ |r| r.id }.values_at(*ids))
        end

    February 5th, 2011 @ 02:05 AM