This project is archived and is in readonly mode.
"ambiguous first argument" warning in `test/generators/scaffold_generator_test`
Reported by Jeff Kreeftmeijer | June 16th, 2010 @ 02:30 PM
When running the scaffold_generator tests, I got a bunch of warnings:
./test/generators/scaffold_generator_test.rb:21: warning: ambiguous first argument; put parentheses or even spaces
./test/generators/scaffold_generator_test.rb:26: warning: ambiguous first argument; put parentheses or even spaces
./test/generators/scaffold_generator_test.rb:29: warning: ambiguous first argument; put parentheses or even spaces
./test/generators/scaffold_generator_test.rb:33: warning: ambiguous first argument; put parentheses or even spaces
./test/generators/scaffold_generator_test.rb:37: warning: ambiguous first argument; put parentheses or even spaces
./test/generators/scaffold_generator_test.rb:41: warning: ambiguous first argument; put parentheses or even spaces
./test/generators/scaffold_generator_test.rb:45: warning: ambiguous first argument; put parentheses or even spaces
./test/generators/scaffold_generator_test.rb:46: warning: ambiguous first argument; put parentheses or even spaces
./test/generators/scaffold_generator_test.rb:47: warning: ambiguous first argument; put parentheses or even spaces
./test/generators/scaffold_generator_test.rb:51: warning: ambiguous first argument; put parentheses or even spaces
./test/generators/scaffold_generator_test.rb:52: warning: ambiguous first argument; put parentheses or even spaces
./test/generators/scaffold_generator_test.rb:53: warning: ambiguous first argument; put parentheses or even spaces
./test/generators/scaffold_generator_test.rb:57: warning: ambiguous first argument; put parentheses or even spaces
./test/generators/scaffold_generator_test.rb:58: warning: ambiguous first argument; put parentheses or even spaces
./test/generators/scaffold_generator_test.rb:95: warning: ambiguous first argument; put parentheses or even spaces
I've included a patch (it's in the next message) that wraps all
arguments of every assert_match
in parentheses. :)
Comments and changes to this ticket
-
Jeff Kreeftmeijer June 16th, 2010 @ 02:31 PM
- no changes were found...
-
Jeff Kreeftmeijer June 16th, 2010 @ 02:32 PM
- Tag set to generators, patch, warnings
-
Jeff Kreeftmeijer September 9th, 2010 @ 05:52 PM
I found this one while cleaning up my watched tickets and updated the patch to apply to master again. Here it is. :)
-
Repository September 24th, 2010 @ 08:18 PM
- State changed from new to resolved
(from [d82d98dcd53704a2d61463768f8690eaa5acfd2b]) got rid of the "ambiguous first argument; put parentheses or even spaces" warnings in the scaffold_generator tests [#4872 state:resolved]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/d82d98dcd53704a2d61463768f8690... -
Repository September 24th, 2010 @ 08:19 PM
(from [109c37b73f78c5b7b45e52599ff08674470cdc56]) got rid of the "ambiguous first argument; put parentheses or even spaces" warnings in the scaffold_generator tests [#4872 state:resolved]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/109c37b73f78c5b7b45e52599ff086...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Attachments
Tags
Referenced by
- 4863 Rails Generator --singleton Aaand another one. This is the same as the previous patch...
- 4872 "ambiguous first argument" warning in `test/generators/scaffold_generator_test` (from [d82d98dcd53704a2d61463768f8690eaa5acfd2b]) got rid...
- 4872 "ambiguous first argument" warning in `test/generators/scaffold_generator_test` (from [109c37b73f78c5b7b45e52599ff08674470cdc56]) got rid...