Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Kernel.silence_stream is not thread-safe

#4946

Hello, consider code http://github.com/rails/rails/blob/53c13f1acaa2eb05e7f418b53f6156a4... running in a Ruby VM with support for multiple threads. It is possible that following happens

thread 1: old_stream = stream.dup
thread 1: stream.reopen('/dev/null')
thread 2: old_stream = stream.dup
thread 2: stream.reopen('/dev/null')
thread 1: stream.reopen(old_stream)
thread 2: stream.reopen(old_stream)

This results in stdout bein permanently set to /dev/null, instead of being set to something usual. In JRuby, in turn, this leads to a cascade of other bad behaviour (somehow, the output buffer overruns and then every "puts" yields an exceptiopn).

In general, every access to "reopen" should be carefully reviewed.

Reported by xbaldauf · June 23rd, 2010 @ 12:25 PM

State: stale
Milestone: none
Assigned to: josh josh
Importance: none

Activity

  1. Santiago Pastorino
    Santiago Pastorino
    • State changed from new to open

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    February 2nd, 2011 @ 05:01 PM

  2. Santiago Pastorino
    Santiago Pastorino
    • State changed from open to stale

    February 2nd, 2011 @ 05:01 PM