Racing Inside ActiveSupport::Dependencies

Same test, modified to run with activesupport 2.0.2

Jeremy,

While you are working in there, would you fix the typo in will_unload?. It is currently:

def will_unload?(const_desc)

autoloaded?(desc) ||

explicitly_unloadable_constants.include?(to_constant_name(const_desc))

end

but should be:

def will_unload?(const_desc)

autoloaded?(const_desc) ||

explicitly_unloadable_constants.include?(to_constant_name(const_desc))

end

Note the autoloaded line. I will make a separate ticket if necessary.

Thanks!

DrMark

Here's a patch that fixes the problem.

DrMark, will_unload? appears to be completely unused. Do you use it?

Hi Jeremy,

Yes. The benchmarkforrails plugin uses it (among others). I thought that it was odd that a bug that obvious could get through :)

If you could fix it or remove it that would be great. That would save me having to monkey patch it all the time :)

Thanks!

Quite so, DrMark. I fixed it in master, 2-1-stable, and 2-0-stable. How odd.

Here are links to two related bugs in ruby's implementation of require when used with threads:

require is not thread-safe http://redmine.ruby-lang.org/iss...

autoload is not thread-safe http://redmine.ruby-lang.org/iss...

Basically there does not appear to be a safe way for require to work in a multi-threaded application unless the first use of require locks until the require is complete.