This project is archived and is in readonly mode.
[PATCH] Warning about method redefined in active_model
#5072
When runnign test suite there are warnings:
/Users/strzalek/projects/ruby/rails_source/activemodel/lib/active_model/observing.rb:161: warning: method redefined; discarding old observed_classes
/Users/strzalek/projects/ruby/rails_source/activemodel/lib/active_model/observing.rb:161: warning: previous definition of observed_classes was here
/Users/strzalek/projects/ruby/rails_source/activemodel/lib/active_model/observing.rb:161: warning: method redefined; discarding old observed_classes
/Users/strzalek/projects/ruby/rails_source/activemodel/lib/active_model/observing.rb:161: warning: previous definition of observed_classes was here
/Users/strzalek/projects/ruby/rails_source/activemodel/lib/active_model/observing.rb:161: warning: method redefined; discarding old observed_classes
/Users/strzalek/projects/ruby/rails_source/activemodel/lib/active_model/observing.rb:161: warning: previous definition of observed_classes was here
/Users/strzalek/projects/ruby/rails_source/activemodel/lib/active_model/observing.rb:161: warning: method redefined; discarding old observed_classes
/Users/strzalek/projects/ruby/rails_source/activemodel/lib/active_model/observing.rb:161: warning: previous definition of observed_classes was here
There are 2 ways to avoid this warning. First is to alias old method, second is to remove it. As it isn't no longer used I think it can be removed.
Patch attached.
-
Repository- State changed from new to resolved
(from [4a26a292a0708df595662444e8c738ee1520ec57]) Removing method before redefining it. It was causing warnings. [#5072 [PATCH] Warning about method redefined in active_model state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/4a26a292a0708df595662444e8c738...