This project is archived and is in readonly mode.
incorrect deprecation notice in ActiveModel::Errors
-
Jakub Suder
- Title changed from ActiveModel::Errors causes a deprecation notice on itself to incorrect deprecation notice in ActiveModel::Errors
Oops, my bad, that was actually an issue with Mongoid, not ActiveModel.
The deprecation message is confusing though, it looks like it was copy-pasted from another method. Instead of:
"ActiveModel::Errors#generate_message(attributes, custom_message) has been deprecated. Use ActiveModel::Errors#generate_message(attributes, :message => 'your message') instead."
it should be something like:
"ActiveModel::Errors#generate_message(attributes, :default => 'your message') has been deprecated. Use ActiveModel::Errors#generate_message(attributes, :message => 'your message') instead."
(The warning is caused by using the key :default in the options, not by passing a string as second argument, which probably wouldn't work at all.)
-
Rohit Arondekar
- State changed from new to invalid
- Importance changed from to Low