#5277 Rails 3.0.0.RC responds strangely to empty Accept header - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5277 open

Rails 3.0.0.RC responds strangely to empty Accept header

Reported by Erik Hetzner | August 2nd, 2010 @ 11:14 PM

If an HTTP client fails to supply an Accept header, this should, I think, be considered equivalent to a "*/*" Accept header. From RFC 2616, section 14.1:

If no Accept header field is present, then it is assumed that the client accepts all media types.

Attached is a patch that adds a (failing) test for this behavior.

empty_accept_header_test.diff 667 Bytes

Comments and changes to this ticket

Ryan Bigg October 11th, 2010 @ 02:09 AM
- State changed from “new” to “needs-more-info”
- Importance changed from “” to “Low”
Please confirm that this is still an issue on 3.0.
You flagged this item as spam.
Erik Hetzner October 11th, 2010 @ 03:19 AM
My test still fails with the latest from git.

Attaching a patch according to instructions at https://rails.lighthouseapp.com/projects/8994/sending-patches
- empty_accept_header_test_2.diff 1005 Bytes
Ryan Bigg October 11th, 2010 @ 03:22 AM
- State changed from “needs-more-info” to “open”
Thank you, I'll mark this as open.
Ryan Bigg October 19th, 2010 @ 08:24 AM
Automatic cleanup of spam.
Santiago Pastorino February 2nd, 2011 @ 04:48 PM
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
Santiago Pastorino February 2nd, 2011 @ 04:48 PM
- State changed from “open” to “stale”
You flagged this item as spam.
Erik Hetzner February 2nd, 2011 @ 08:19 PM
- State changed from “stale” to “open”
Yes, my submitted test still fails with the latest 3-0-stable branch. No new information.

[state:open]
rails May 3rd, 2011 @ 01:00 AM
This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
rails May 3rd, 2011 @ 01:00 AM
- State changed from “open” to “stale”
You flagged this item as spam.
Erik Hetzner May 3rd, 2011 @ 05:50 PM
Still an issue. Attaching a new failing test against master.
- empty_accept_header_test_3.diff 1 KB
You flagged this item as spam.
Erik Hetzner May 3rd, 2011 @ 05:51 PM
- State changed from “stale” to “open”
[state:open]