This project is archived and is in readonly mode.

#5315 ✓resolved
Sven Fuchs

update_attribute regression

Reported by Sven Fuchs | August 6th, 2010 @ 11:34 AM | in 3.0.2

I stumbled across this while fixing vestal_versions for a Rails 3 project.

This change breaks the way update_all, dirty tracking and after_save callbacks worked together at least for this particular library (vestal_version) but I'd imagine it breaks a bunch of other implementations, too.

I still wonder what the reasoning behind this change is, but also think that it's a regression and should be reverted:

To demonstrate the issue I've added this test to my vestal_versions fork:

The first test passes, the second one fails on AR 3 (where both were passing on AR 2.3.x). Reverting the implementation of update_attribute back to what it was in AR 2.3.x makes the second test pass, too.

If there's an intention of breaking the API in AR 3 and introducing something more consistent for some reason then I'd propose to either

  1. make update_attribute behave exactly the same way as update_attributes does
  2. have another method that does not use validations, callbacks, dirty tracking and pick a name that actually communicates this behaviour


  1. simply use the same api as save(:validate => true) uses

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket