This project is archived and is in readonly mode.
references_eager_loaded_tables? matches numbers with decimals
Reported by Peter Wagenet | July 2nd, 2008 @ 02:26 AM | in 2.x
ActiveRecord::Associations::ClassMethods#references_eager_loaded_tables? will return true if any decimal numbers exist in the query. This is due to the conditions_tables, order_tables, and selects_tables methods not being very discriminating in their Regexps. I'll be submitting a patch for this soon.
Comments and changes to this ticket
-
Peter Wagenet July 3rd, 2008 @ 02:29 AM
- Tag changed from “activerecord, bug, eager_loading” to “activerecord, bug, eager_loading, patch”
Patch included now.
-
Pratik July 4th, 2008 @ 12:20 AM
- State changed from “new” to “incomplete”
Hi Peter,
Your patch is missing tests. Could you please add a failing test case as well ? ( which will fail before applying the fix and pass afterwards )
Thanks.
-
-
Peter Wagenet August 18th, 2008 @ 04:01 PM
Is there anything else delaying this from being approved?
-
Pratik August 18th, 2008 @ 04:34 PM
- State changed from “incomplete” to “open”
- Tag changed from “activerecord, bug, eager_loading, patch” to “activerecord, bug, eager_loading, patch, tested”
-
Repository August 21st, 2008 @ 05:24 PM
- State changed from “open” to “resolved”
(from [8622787f8748434b4ceb2b925a35b17a38e1f2d6]) Don't interpret decimals as table names in ActiveRecord::Associations::ClassMethods#references_eager_loaded_tables? [#532 state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
-
Repository August 25th, 2008 @ 09:31 AM
(from [104220ed2c2c2ed67100f5022cd538e3e9f1acec]) Don't interpret decimals as table names in ActiveRecord::Associations::ClassMethods#references_eager_loaded_tables? [#532 state:resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Peter Wagenet
Pratik
Attachments
Referenced by
-
532
references_eager_loaded_tables? matches numbers with decimals
(from [8622787f8748434b4ceb2b925a35b17a38e1f2d6]) Don't i...
-
532
references_eager_loaded_tables? matches numbers with decimals
(from [104220ed2c2c2ed67100f5022cd538e3e9f1acec]) Don't i...
-
3446
tables_in_string matches literal string containing dot
I provide a patch that tests for the problem and fixes it...