Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

You must be a member of this account.

This project is archived and is in readonly mode.

ActionDispatch::TestResponse duplicates Rack::Response functionality

#5320

Rack::Response::Helpers (included in Rack::Response) provides #successful?, #redirection?, #client_error?, #server_error?, and #not_found?, with identical semantics to equivalent ActionDispatch::TestResponse methods.

Therefore:

  • success? can be aliased to successful? or deprecated.
  • missing? can be aliased to not_found? or deprecated.
  • redirect? can be aliased to redirection? or deprecated.
  • client_error? and server_error? can be removed.
  • error? can be aliased to server_error? or deprecated.

If we deprecate these methods, .from_response will remain the only non-deprecated functionality provided by ActionDispatch::TestResponse.

Reported by John Firebaugh · August 6th, 2010 @ 07:30 PM

State: resolved
Milestone: none
Assigned to: nobody
Importance: none

Activity