Prototype helpers should generate Element.insert instead of Insertion.new

Third time updating the patch so it can be merged...

Any comments?

+1

There is a typo in RDoc: missing opening double quote here:

new Element.insert("list", { bottom: <li>Some item</li>" });

The patch seems a bit large and certain parts very hackish. Still, I haven't had time to actually study RJS code in depth. Are you sure this is in its simplest form?

Mislav, thanks for your feedback.

I have fixed the typo in docrails:

http://github.com/lifo/docrails/...

About the patch being large, i don't quite agree, i did have to change tests to match the new output and update docs.

I do agree selector_assertions is a very hackish helper, as it was before the patch. I'll try to work on it and create a new ticket with the results.

Thanks again for you comments.

I've improved selector_assertion by: - Making use of constants that were defined but never used. - Improving the readability of the code. - Adding test to untested code. - Simplifying Regexps.

This second patch applies on the current version, that would be after the first patch of this ticket was commited.

Anyway, the former patch works well and the later one is just and improvement to code that was already in.

The code is a bit shorter, nicer, and adds a missing test.

+1 from me

First patch applied in http://github.com/rails/rails/co...

I have ran the test against the branches 2-1-stable and 2-0-stable (before any of these patches were commited), and the test fails on both, i can't see either were the previous code verified the double insertion to raise any error.

By the way, should an error be raised in that situation?