JSON serialization is broken

I've just sent a pull request with my proposed patch. The test to reproduce the problem is below:

require 'rubygems'
require 'active_model'
require 'active_support/core_ext'
require 'active_support/json'

class User
  include ActiveModel::Serialization
  include ActiveModel::Serializers::JSON

  attr_accessor :name

  def attributes
    @attributes ||= {'name' => 'nil'}
  end
end

u = User.new
u.name = 'kent'

json = { :user => u, :x => { :name => 1 } }.to_json
puts json # => {"user":{"user":{"name":"kent"}},"x":{"name":1}}

options = {}
json = { :user => u, :x => { :name => 1 } }.to_json( options )

puts json # => {"user":{"user":{"name":"kent"}},"x":{}}
p options # => {:except=>[], :only=>[]}

My ignorance prevents me from implementing proper test cases. Sorry.

So could you please create a patch from your pull request and attach it here? It will allow other people to create a test case for your patch so it can be finally applied.

Here we go. The diff is attached.

FYI: I'm going to start making a test for this now.

There you go:

Hello,

Im having trouble overriding the as_json method in one of my models,

Is this issue related to my problem?

Thanks

Adrian,

Maybe, maybe not - I can't tell. Why don't you hop into #railsbridge at irc.freenode.org and ping me there? I'm dtrasbo.

Thanks David, I'll do that

Awesome. FYI, I'm in there now if you have time.

Kent, could you please rebase your patch? Sorry but it no longer applies.

You can close this ticket, since it looks like the required changes have been submitted already with another patch.

Thanks.