This project is archived and is in readonly mode.
Relation fails to act like an Array on intersection
ActivceRecord::Relations tries hard to act like an Array, but it fails when it comes to intersection (#&).
Test appended.
-
relation_test.diff
1.02 KB
-
Marcelo Giorgi- Assigned user set to Santiago Pastorino
- Tag set to patch
Hi,
I've just create a couple of patches to make this work.
First, I tried to apply Kane's test but I couldn't (on master). So, I've just copied the idea of the test (only used with a different model so that we don't need to load books fixture in this file) and added a first patch with Kane as author.
Then, my second patch is the working code that makes the test to pass.
-
Kanenice!
this is exacly what i had in mind.
No problems while appling it to current master.
I think the test is straight forward, so is the implementation. +1 from me -
Nathan Kleyn- Tag changed from patch to active record, activerecord relation, patch
This applied fine for me, and seems to be exactly what's needed. +1 from me too.
-
max.pettersenThe implementation seems to be correct for me, and also the test passes properly. +1
-
Marcelo Giorgi
- Tag changed from active record, activerecord relation, patch to active record, activerecord relation, patch, verified
Adding the verified tag now that 3 people have voted positively.
-
Rizwan Reza- Importance changed from to Low
Hey Marcelo,
Can you send a pull request on Github to rails/rails for this one?
Thanks!
-
-
Mikel Lindsaar- Assigned user changed from Santiago Pastorino to Mikel Lindsaar
OK, I am testing this now.
-
Mikel Lindsaar
- State changed from new to committed