This project is archived and is in readonly mode.
Use `Time.current` in AS::CoreExtensions::Numeric::Time to maintain consistency with AS::Duration
Hi,
After I was investigate with #4076 ago (ActiveSupport::CoreExtensions::Numeric::Time) does not respect current t..., I
found out that ago and since in
ActiveSupport::CoreExtensions::Numeric::Time was
actually using Time.now when user doesn't specify the
time. However, I found out in the old commit (http://github.com/rails/rails/commit/32b82e4c#L2L54)
that Geoff Buesing has switched to use Time.current to
use the time zone specified in Time.default_zone
instead.
So, I have made the patches to change those two lines to use
Time.current instead of Time.now to make
it consistence. Please review and apply them for me.
Thank you.
-
master_time_current_fix.diff
1.24 KB
-
2-3-stable_time_current_fix.diff
1.35 KB
-
Prem Sichanugrist (sikachu)- Assigned user changed from José Valim to Santiago Pastorino
Santiago, could you please apply this patch for me?
Thank you :D
-
Santiago PastorinoPrem the patch looks good, do you mind to add tests the same way Geoff did.
Thanks. -
Prem Sichanugrist (sikachu)
Here is the patch with tests added. Actually, I was copied the test from Geoff as it tests the same thing. I can confirm that it is failing before the applying the change :)
Thank you
-
master_time_current_fix.diff
3.25 KB
-
2-3-stable_time_current_fix.diff
3.36 KB
-
-
Prem Sichanugrist (sikachu)
Oh wait, I shouldn't say copy. I copy and 'modified' it.
Thanks :)
-
Repository
- State changed from new to committed
(from [af6757a1ca7027b526b35d74c94a520d6bb24d7a]) Use
Time.currentto maintain consistency with AS::DurationIn [32b82e4c6f5523cdf5ee78c3022c50b46e018351], the committer has switch
methods in AS::Duration to useTime.currentto return the correct
duration based on theTime.default_zoneinstead of usingTime.now.[#5607 Use `Time.current` in AS::CoreExtensions::Numeric::Time to maintain consisten... state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/af6757a1ca7027b526b35d74c94a52... -
Repository
(from [e125bf264eeedf4251010eb2989dc8e5b8e33d86]) Use
Time.currentto maintain consistency with AS::DurationIn [32b82e4c6f5523cdf5ee78c3022c50b46e018351], the committer has switch
methods in AS::Duration to useTime.currentto return the correct
duration based on theTime.default_zoneinstead of usingTime.now.[#5607 Use `Time.current` in AS::CoreExtensions::Numeric::Time to maintain consisten... state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/e125bf264eeedf4251010eb2989dc8... -
Santiago Pastorino
- Milestone changed from 3.x to 2.3.10
- State changed from committed to open
- Assigned user changed from Santiago Pastorino to Geoff Buesing
-
Prem Sichanugrist (sikachu)
Santiago, why reopen? Is there anything else I can do?
-
Santiago Pastorino
No it's ok i applied your patch on 3-0-stable and master. But ... you added a patch for 2-3-stable too and i didn't applied it.
That's why i reopened for Milestone 2.3.10. -
Prem Sichanugrist (sikachu)
- State changed from open to resolved
I don't think this needed to be applied anymore, as our momentum is moving toward Rails 3. :)