This project is archived and is in readonly mode.
Use `Time.current` in AS::CoreExtensions::Numeric::Time to maintain consistency with AS::Duration
Reported by Prem Sichanugrist (sikachu) | September 10th, 2010 @ 04:56 PM | in 2.3.10
Hi,
After I was investigate with #4076, I
found out that ago and since in
ActiveSupport::CoreExtensions::Numeric::Time was
actually using Time.now when user doesn't specify the
time. However, I found out in the old commit (http://github.com/rails/rails/commit/32b82e4c#L2L54)
that Geoff Buesing has switched to use Time.current to
use the time zone specified in Time.default_zone
instead.
So, I have made the patches to change those two lines to use
Time.current instead of Time.now to make
it consistence. Please review and apply them for me.
Thank you.
Comments and changes to this ticket
-
Prem Sichanugrist (sikachu) September 11th, 2010 @ 09:35 AM
- Assigned user changed from “José Valim” to “Santiago Pastorino”
Santiago, could you please apply this patch for me?
Thank you :D
-
Santiago Pastorino September 12th, 2010 @ 02:32 AM
Prem the patch looks good, do you mind to add tests the same way Geoff did.
Thanks. -
Prem Sichanugrist (sikachu) September 12th, 2010 @ 08:19 AM
Here is the patch with tests added. Actually, I was copied the test from Geoff as it tests the same thing. I can confirm that it is failing before the applying the change :)
Thank you
-
Prem Sichanugrist (sikachu) September 12th, 2010 @ 08:19 AM
Oh wait, I shouldn't say copy. I copy and 'modified' it.
Thanks :)
-
Repository September 19th, 2010 @ 07:26 PM
- State changed from “new” to “committed”
(from [af6757a1ca7027b526b35d74c94a520d6bb24d7a]) Use
Time.currentto maintain consistency with AS::DurationIn [32b82e4c6f5523cdf5ee78c3022c50b46e018351], the committer has switch
methods in AS::Duration to useTime.currentto return the correct
duration based on theTime.default_zoneinstead of usingTime.now.[#5607 state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/af6757a1ca7027b526b35d74c94a52... -
Repository September 19th, 2010 @ 07:47 PM
(from [e125bf264eeedf4251010eb2989dc8e5b8e33d86]) Use
Time.currentto maintain consistency with AS::DurationIn [32b82e4c6f5523cdf5ee78c3022c50b46e018351], the committer has switch
methods in AS::Duration to useTime.currentto return the correct
duration based on theTime.default_zoneinstead of usingTime.now.[#5607 state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
http://github.com/rails/rails/commit/e125bf264eeedf4251010eb2989dc8... -
Santiago Pastorino September 19th, 2010 @ 08:16 PM
- Milestone changed from “3.x” to “2.3.10”
- State changed from “committed” to “open”
- Assigned user changed from “Santiago Pastorino” to “Geoff Buesing”
-
Prem Sichanugrist (sikachu) September 20th, 2010 @ 02:43 AM
Santiago, why reopen? Is there anything else I can do?
-
Santiago Pastorino September 20th, 2010 @ 04:39 AM
No it's ok i applied your patch on 3-0-stable and master. But ... you added a patch for 2-3-stable too and i didn't applied it.
That's why i reopened for Milestone 2.3.10. -
Prem Sichanugrist (sikachu) November 19th, 2010 @ 01:22 PM
- State changed from “open” to “resolved”
I don't think this needed to be applied anymore, as our momentum is moving toward Rails 3. :)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Geoff Buesing
Jeremy Kemper
José Valim
Prem Sichanugrist (sikachu)
Santiago Pastorino
