This project is archived and is in readonly mode.
[Patch] Rails3 - accepts_nested_attributes_for reject_if => {blank id} raises ActiveRecord::RecordNotFound when id is an empty string
-
Nathan B
excellent
-
Neeraj Singh
- Importance changed from to Low
Not sure how much of overlap is there between this ticket and #5579 . I will look into that later.
-
José Valim
- Milestone cleared.
- Assigned user set to José Valim
-
Jeremy Kemper
- Milestone set to 3.0.2
-
Ryan Bigg
Automatic cleanup of spam.
-
Jeff Kreeftmeijer
Automatic cleanup of spam.
-
Neeraj Singh
- State changed from new to open
- Tag set to patched
+1
Reviewing this patch as per request from Santiago. Tested the patch and it looks good.
-
José Valim
- Assigned user changed from José Valim to Santiago Pastorino
Yup, it looks good. I want just to note that in Rails Code Guidelines is stated that we don't use "not". So this would probably be better written as !a["id"].blank? or a["id"].present?
-
Repository
- State changed from open to committed
(from [894fd288596b005148c3882e6431f6453d198101]) Fixed bug in active_record/nested_attributes where an empty string id caused an ActiveRecord::RecordNotFound error. Found by [Ben Tillman]
[#5638 state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
https://github.com/rails/rails/commit/894fd288596b005148c3882e6431f... -
Repository
(from [d54ab371df9eb34ce26386a6656144e81eadc4b3]) Fixed bug in active_record/nested_attributes where an empty string id caused an ActiveRecord::RecordNotFound error. Found by [Ben Tillman]
[#5638 state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
https://github.com/rails/rails/commit/d54ab371df9eb34ce26386a665614...
