Rails Ruby on Rails

Comments and changes to this ticket

• You flagged this item as spam.
  

  Tsutomu Kuroda October 1st, 2010 @ 02:22 PM

  Hi, Anton

  The object_name may have plural form before '_attributes'.

  You should singularize the base_name like:

    base_name = $1.singularize
  

  But, I propose the following modification:

    base_name = object.class.name.underscore
  

  because the object name can be different from the model name.

• You flagged this item as spam.
  

  Anton Bangratz October 1st, 2010 @ 05:34 PM

  Thank you,

  I have added the suggestions. The tests suggest that the method works - finding where the object comes from was a bit ominous at first glance.

  Still, I have two separate patches to implement either solution - anyone will have to apply them in order.

  Anton

  • 0002-human-attribute-names-for-nested-labels.patch 2.7 KB
  • 0003-human-attributes-for-labels-using-the-object-name.patch 1 KB

• You flagged this item as spam.
  

  Tsutomu Kuroda October 8th, 2010 @ 08:15 PM

  Anton,

  I changed my mind about this theme. Now I think that the current implementation is correct.

  Here is the relevant code snipet from form_helper.rb:

    content = if text.blank?
      I18n.t("helpers.label.#{object_name}.#{method_name}", :default => "").presence
    else
      text.to_s
    end
  
    content ||= if object && object.class.respond_to?(:human_attribute_name)
      object.class.human_attribute_name(method_name)
    end
  
    content ||= method_name.humanize
  

  The class method human_attribute_name looks into the lang.activerecord.attributes.author namespace. The YAML file will go as follow:

  ja:
    activerecord:
      attributes:
        author:
          name: 名前
  

  This is the normal and traditional way to translate the label text.

  Alternatively, we can provide texts in the lang.helpers.label.post[author_attributes] namespace like this:

  ja:
    helpers:
      label:
        post[author_attributes]:
          name: 投稿者名
  

  We might want to provide other texts for the attributes of the Author model nested in the another model, say Article. In this case, we will modify the YAML file as follows:

  ja:
    helpers:
      label:
        post[author_attributes]:
          name: 投稿者名
        article[author_attributes]:
          name: 筆者名
  

  I am happy with this behaviour.

• 

  Ryan Bigg October 19th, 2010 @ 08:22 AM

  • Tag cleared.
  • Importance changed from “” to “Low”

  Automatic cleanup of spam.

• 

  Santiago Pastorino February 2nd, 2011 @ 04:29 PM

  • State changed from “new” to “open”

  This issue has been automatically marked as stale because it has not been commented on for at least three months.

  The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

  Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

• 

  Santiago Pastorino February 2nd, 2011 @ 04:29 PM

  • State changed from “open” to “stale”