Label form helper and I18n with nested attributes does not work

Hi, Anton

The object_name may have plural form before '_attributes'.

You should singularize the base_name like:

  base_name = $1.singularize

But, I propose the following modification:

  base_name = object.class.name.underscore

because the object name can be different from the model name.

Thank you,

I have added the suggestions. The tests suggest that the method works - finding where the object comes from was a bit ominous at first glance.

Still, I have two separate patches to implement either solution - anyone will have to apply them in order.

Anton

Anton,

I changed my mind about this theme. Now I think that the current implementation is correct.

Here is the relevant code snipet from form_helper.rb:

  content = if text.blank?
    I18n.t("helpers.label.#{object_name}.#{method_name}", :default => "").presence
  else
    text.to_s
  end

  content ||= if object && object.class.respond_to?(:human_attribute_name)
    object.class.human_attribute_name(method_name)
  end

  content ||= method_name.humanize

The class method human_attribute_name looks into the lang.activerecord.attributes.author namespace. The YAML file will go as follow:

ja:
  activerecord:
    attributes:
      author:
        name: 名前

This is the normal and traditional way to translate the label text.

Alternatively, we can provide texts in the lang.helpers.label.post[author_attributes] namespace like this:

ja:
  helpers:
    label:
      post[author_attributes]:
        name: 投稿者名

We might want to provide other texts for the attributes of the Author model nested in the another model, say Article. In this case, we will modify the YAML file as follows:

ja:
  helpers:
    label:
      post[author_attributes]:
        name: 投稿者名
      article[author_attributes]:
        name: 筆者名

I am happy with this behaviour.